Fix item field ordering on save_object
#1423
Merged
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
feature/item-field-ordering
branch
from
074f79f to
bee2978
Compare
|
@jsignell I think this ought to be good to go |
moradology
force-pushed
the
feature/item-field-ordering
branch
from
bee2978 to
d5fb435
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
+ Coverage 91.20% 91.21% +0.01%
==========================================
Files 52 52
Lines 7239 7237 -2
Branches 1019 1018 -1
==========================================
- Hits 6602 6601 -1
Misses 457 457
+ Partials 180 179 -1 ☔ View full report in Codecov by Sentry. |
gadomski
requested changes
Oct 3, 2024
moradology
force-pushed
the
feature/item-field-ordering
branch
from
a8d6daf to
b2cc0e7
Compare
gadomski
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
This PR fixes item field ordering in accordance with the order defined here. Additionally, I've fixed what appears to be a small configuration error in pre-commit.config.yaml such that ruff-format wasn't actually fixing ill-formatted files.
PR Checklist:
scripts/test)