Add support to validate_all for STACObject #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
gadomski
requested changes
Sep 28, 2023
chuckwondo
force-pushed
the
issues/1206-validate-all-stacobject
branch
from
fafee0c to
7c5c83e
Compare
gadomski
reviewed
Sep 29, 2023
gadomski
approved these changes
Sep 29, 2023
Specifically: - add `validate_all_dict` function for validating objects as dicts (i.e., rename original `validate_all` function) - deprecate support for passing dict objects to `validate_all` (use new `validate_all_dict` function instead) - add support for passing `STACObject` to `validate_all` (and prohibit passing a value for `href` when passing a `STACObject`) Fixes stac-utils#1205
auto-merge was automatically disabled
September 29, 2023 09:14
Head branch was pushed to by a user without write access
chuckwondo
force-pushed
the
issues/1206-validate-all-stacobject
branch
from
1686fd8 to
a26747c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
validate_all_dictfunction for validating objects as dicts (i.e., rename originalvalidate_allfunction)validate_all(use newvalidate_all_dictfunction instead)STACObjecttovalidate_all(and prohibit passing a value forhrefwhen passing aSTACObject)PR Checklist:
pre-commithooks pass locallyscripts/test)