Skip to content

Update EO extension to v1.1.0 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 25, 2023
Merged

Update EO extension to v1.1.0 #1131

merged 6 commits into from
May 25, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented May 23, 2023

Related Issue(s):

Description:

The solar_illumination field was already in the extension class, so I only needed to add eo:snow_cover.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell linked an issue May 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (add2fe9) 90.35% compared to head (8ef66d3) 90.38%.

❗ Current head 8ef66d3 differs from pull request most recent head c9eff2c. Consider uploading reports for the commit c9eff2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   90.35%   90.38%   +0.03%     
==========================================
  Files          48       48              
  Lines        6343     6367      +24     
  Branches      944      947       +3     
==========================================
+ Hits         5731     5755      +24     
  Misses        431      431              
  Partials      181      181              
Impacted Files Coverage Δ
pystac/extensions/eo.py 93.85% <100.00%> (+0.67%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski self-requested a review May 25, 2023 14:29
@gadomski gadomski added this to the 1.8 milestone May 25, 2023
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for including the test for the old version as well 👍🏼.

@gadomski gadomski added this pull request to the merge queue May 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2023
gadomski added 2 commits May 25, 2023 08:38
We just enabled ruff's import sorting.
@gadomski gadomski enabled auto-merge May 25, 2023 14:46
@gadomski gadomski added this pull request to the merge queue May 25, 2023
Merged via the queue into stac-utils:main with commit fdeb703 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EO extension to v1.1.0
2 participants