Skip to content

Update notebook links to not point to specific versions #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2023
Merged

Update notebook links to not point to specific versions #1039

merged 5 commits into from
Mar 21, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Mar 14, 2023 •
edited
Loading

Related Issue(s):

Description:

According to the issue description these should be the last links. I think we can tackle updating the landsat doc (#149 (comment)) separately.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

gadomski
gadomski requested changes Mar 14, 2023
View reviewed changes
@gadomski gadomski added this to the 1.8 milestone Mar 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (0f9ff83) to head (fd39965).
Report is 258 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          47       47           
  Lines        6213     6213           
  Branches      929      929           
=======================================
  Hits         5613     5613           
  Misses        422      422           
  Partials      178      178

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsignell jsignell requested a review from gadomski March 14, 2023 21:07
gadomski
gadomski requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsignell will this close #149?

@gadomski gadomski modified the milestones: 1.8, 1.7.1 Mar 16, 2023
@jsignell
Copy link
Member Author

@jsignell will this close #149?

Yes, I believe so. But I haven't opened a second ticket for #149 (comment)

@gadomski gadomski linked an issue Mar 20, 2023 that may be closed by this pull request
Enable automatically adjusting the STAC version in documentation #149
Closed
@gadomski gadomski added this pull request to the merge queue Mar 21, 2023
@gadomski
Copy link
Member

Opened #1056 to track the landsat issue.

@gadomski gadomski merged commit 93e4237 into stac-utils:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

Enable automatically adjusting the STAC version in documentation
3 participants
@jsignell @codecov-commenter @gadomski