Skip to content

fix: permissive extent parsing for collections #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix: permissive extent parsing for collections #787

merged 3 commits into from
Feb 11, 2025

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Feb 10, 2025 •
edited
Loading

Related Issue(s):

Description:

We were overly strict when parsing collections, causing an error when the collections are invalid (which happens out there quite a lot).

cc @ceholden @aliziel

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from hrodmn February 10, 2025 23:44
@gadomski gadomski self-assigned this Feb 10, 2025
@gadomski gadomski marked this pull request as draft February 10, 2025 23:44
@gadomski gadomski marked this pull request as ready for review February 10, 2025 23:48
hrodmn
hrodmn approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - when I have found invalid collections it is usually an extent problem.

@gadomski gadomski merged commit 86a0ad8 into main Feb 11, 2025
14 checks passed
@gadomski gadomski deleted the issues/786-permissive-read branch February 11, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrodmn hrodmn hrodmn approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make collection search more permissive
2 participants
@gadomski @hrodmn