Skip to content

Include Modifiable at the top-level #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2023
Merged

Include Modifiable at the top-level #534

merged 2 commits into from
Jun 8, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 7, 2023 •
edited
Loading

Related Issue(s):

Description:

We use Modifiable in the signature of Client.open() (among other places) so it should be "public".

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski added this to the 0.7.0 milestone Jun 7, 2023
@gadomski gadomski requested a review from jsignell June 7, 2023 18:48
@gadomski gadomski self-assigned this Jun 7, 2023
@gadomski gadomski merged commit 478fb86 into main Jun 8, 2023
@gadomski gadomski deleted the issues/533-public-modifiable branch June 8, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignell jsignell jsignell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

Make Modifiable "public"
2 participants
@gadomski @jsignell