-
Notifications
You must be signed in to change notification settings - Fork 51
Add lru_caches #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lru_caches #167
Conversation
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 81.00% 81.20% +0.20%
==========================================
Files 9 9
Lines 558 564 +6
==========================================
+ Hits 452 458 +6
Misses 106 106
Continue to review full report at Codecov.
|
2c0133c
to
b54bd0e
Compare
b54bd0e
to
5407c8c
Compare
5407c8c
to
5ba4cbd
Compare
@philvarner sorry to re-request review, but I forgot |
Only applying to functions that return fully-fetched values (e.g. an ItemCollection). Not applying to generators.
5ba4cbd
to
3b4b845
Compare
Related Issue(s):
Description:
The LRU caches are only applied to functions that return fully-fetched values (e.g. an ItemCollection), not applied to generators. This limits the number of places the cache can be used.
PR Checklist: