Skip to content

Add resilience4j support #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OlgaMaciaszek opened this issue Nov 15, 2018 · 5 comments
Open

Add resilience4j support #658

OlgaMaciaszek opened this issue Nov 15, 2018 · 5 comments
Labels
backlog enhancement

Comments

@OlgaMaciaszek
Copy link
Contributor

OlgaMaciaszek commented Nov 15, 2018 •
edited
Loading

Probably the best way to do it would be to switch to an abstraction that would work for both Hystrix and resilience4J (and possibly other implementations), so this issue is dependent on adding those changes in commons (spring-cloud/spring-cloud-commons#21).
@gminog
Copy link
Contributor

gminog commented Jan 10, 2019

@OlgaMaciaszek, is this still under consideration?
To my understanding, Spring Cloud Gateway only supports Hystrix for Circuit Breaking. Am I right?

@ryanjbaxter
Copy link
Contributor

Yes support will be added in the future.

@spencergibb spencergibb mentioned this issue Jan 28, 2019
Closed
@RobWin RobWin mentioned this issue Feb 27, 2019
Closed
@eacdy
Copy link
Contributor

eacdy commented Oct 20, 2019

@ryandawsonuk Do we have any plans to support resilience4j?

@ryandawsonuk
Copy link
Contributor

@eacdy I think you mean to ask @ryanjbaxter

@spencergibb
Copy link
Member

That is the purpose of this issue.

Johnny850807 pushed a commit to Johnny850807/spring-cloud-gateway that referenced this issue Dec 14, 2020
@OlgaMaciaszek
Zoned ServiceInstanceListSupplier (spring-cloud#658)
75338cd 
* Get ServiceInstance zone from metadata.

* Add ZonePreferenceServiceInstanceListSupplier.

* Add javadocs and license entries.

* Add tests.

* Add documentation.

* Documentation fix.

* Fix after code review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ryanjbaxter @spencergibb @OlgaMaciaszek @eacdy @spring-projects-issues @ryandawsonuk @gminog