Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for concurrency helpers #1173
base: master
Are you sure you want to change the base?
Add documentation for concurrency helpers #1173
Changes from 1 commit
da44202
dd85cff
f495e9d
65b2caa
ec67cd6
b3344cc
05e6d3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is rather uncommon to use
AsyncConditions
in production code, it might be helpful to show its usage via aMock
/Spy
as this would be closer to its real world usage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Production code? I'm not sure I understand, could you elaborate on what you have in mind here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you somehow need to trigger these
conditions.evaluate
calls. The current examples show the direct usage in the test code viaThread.start
. While that is a nice bare bones example, it does not really help the user to see how he can use that to test his actual production code.One way, is that you'd define a
Spy
and then do something likeservice.foo() >> { conditions.evaluate { ... }; callRealMethod()}
.