Localization (translations) #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some basic translations for settings modal as proof-of-concept
theRealPadster
changed the title
* Add French translation * Fix typo * Remove \ symbol
Fr-CA will fall back to just fr now.
Restructure locale json files, Remove keys from en-US that are same as en
* Update French translation Co-authored-by: Rom <skav@gmx.fr> Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
|
I think I've got all the strings translated and this is ready to go. Please give it a test and see if I missed anything. I'd also like to note that I left the French "dark" and "light" theme tags in English because I wasn't sure which word referred to a colour theme as opposed to somber/gloomy/etc. @xerta555 What would you use for those? |
theRealPadster
requested review from
CharlieS1103
and removed request for
a team
kyrie25
reviewed
Sep 3, 2022
Not having any programming skills (except shell), all the projects I'm involved in for translations use i18n with sites like Crowdin, GetLocalization, OneSky, Transifex and others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added i18next as the library, and added some basic translations for settings modal as a proof of concept. It can detect the language set in Spotify, so we shouldn't need to add an option for it. The translations are stored in different files, so we can have people make PRs and add/update their native language.
Working on the settings modal so far:
