Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Grid): only re-render cards on state change #289

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Conversation

kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Jul 29, 2022

Resolves #106
this is part of the reason why cards refused to re-render on search lol as React won't render new components if they have the same key.

@kyrie25 kyrie25 requested a review from a team as a code owner July 29, 2022 04:35
@kyrie25 kyrie25 requested review from rxri and removed request for a team July 29, 2022 04:35
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added. Please fix the type annotations thing too.

@kyrie25 kyrie25 requested a review from theRealPadster July 29, 2022 08:55
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@kyrie25 kyrie25 merged commit 7faf66c into main Jul 29, 2022
@kyrie25 kyrie25 deleted the fix/card-render branch July 29, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't always re-render every card when a theme is added/removed
2 participants