Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TabRow): Marketplace crashing on moving tabs #235

Merged
merged 4 commits into from
Jun 12, 2022
Merged

Conversation

kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Jun 12, 2022

Fixed an issue where Marketplace would crash on moving tabs to non-existent index

Details
  • Before:
    Spotify_cGbxTCwC9i

  • After:
    Spotify_duNqPErbVF

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably be better with a disabled prop passed in, and just setting it to disabled for the first and last tabrow, so it won't be hard coded into the third one if we add more in the future

@kyrie25
Copy link
Member Author

kyrie25 commented Jun 12, 2022

This would probably be better with a disabled prop passed in, and just setting it to disabled for the first and last tabrow, so it won't be hard coded into the third one if we add more in the future

I'm pretty sure there's no need to change anything for the first row then, will look into the last row.
You shouldn't need to pass in another prop from my recent commit.

@kyrie25 kyrie25 requested a review from theRealPadster June 12, 2022 13:16
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, perfect, that's better

@theRealPadster theRealPadster merged commit 3258fcb into main Jun 12, 2022
@kyrie25 kyrie25 deleted the fix/tabrow branch June 12, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants