Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change workflow runs, add Husky & resolve lint errors #232

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

kyrie25
Copy link
Member

@kyrie25 kyrie25 commented Jun 11, 2022

Testing new changes for Lint CI, should return the following errors:
image

@kyrie25 kyrie25 changed the title test(CI): deploy changes ci: change workflow runs & resolve lint errors Jun 11, 2022
@kyrie25 kyrie25 changed the title ci: change workflow runs & resolve lint errors ci: change workflow runs, add Husky & resolve lint errors Jun 11, 2022
@kyrie25
Copy link
Member Author

kyrie25 commented Jun 11, 2022

Note: Currently stops committing if ESLint fails to fix errors:

image

Workaround: Using the --no-verify flag for git commit which would disable Husky on commit

image

@theRealPadster this should suffice yes?

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theRealPadster theRealPadster merged commit a555110 into main Jun 11, 2022
@kyrie25 kyrie25 deleted the test/ci branch June 11, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants