Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables with the same debugname, used in different scopes for different memory, leads to ambiguities and multiple Locals of the same name #876

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Feb 28, 2024

check for collisions of variable names with different indices - happens with scopes using the same variable names for different memory locations - when incorporating debug names

@swissiety swissiety changed the title check for collisions of variable names with different indices - happe… Variables with the same debugname, used in different scopes for different memory, leads to ambiguities and multiple Locals of the same name Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (9716b4a) to head (348d3b2).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #876      +/-   ##
=============================================
+ Coverage      68.26%   68.28%   +0.02%     
- Complexity      3877     3881       +4     
=============================================
  Files            311      311              
  Lines          15186    15192       +6     
  Branches        2587     2588       +1     
=============================================
+ Hits           10366    10374       +8     
+ Misses          3911     3909       -2     
  Partials         909      909              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ns with scopes using the same variable names for different memory locations - when incorporating debug names
@swissiety swissiety force-pushed the fix/localname_collisions branch from 20c4fac to a3b912b Compare February 28, 2024 10:40
@JonasKlauke JonasKlauke merged commit 79f92e6 into develop Feb 28, 2024
9 checks passed
@JonasKlauke JonasKlauke deleted the fix/localname_collisions branch February 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants