Merge v2.0 #3
Closed
Merge v2.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pull changelog from v1.10.0 in master * Add stylespec CHANGELOG.md
* first draft getting Attribute info some clean-up Code clean-up Addressing PR comments move Regex into the parameter list Remove using Set since some the functionalities of Set is not supported in IE11. * Fixing a render-test failure
Noticed this bug in the documentation of the setup when getting round to contributing a PR.
## Launch Checklist
<!-- Thanks for the PR! Feel free to add or remove items from the checklist. -->
- [x] briefly describe the changes in this PR
- [ ] apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
Co-authored-by: HeyStenson <heather.stenson@mapbox.com>
Updated the compatibility tables for iOS map SDK v5.9.0 and macOS map SDK v0.16.0.
…e symbol-z-order (mapbox#9655) fix mapbox#9617
* Align pattern_attributes to 4-bytes boundaries This was reported as being an issue on failed render tests on AMD graphics cards * Warn on 4-bytes misalignment $ yarn run codegen Warning: The layout StructArrayLayout3ui6 is not aligned to 4-bytes boundaries. Warning: The layout StructArrayLayout3i6 is not aligned to 4-bytes boundaries. Warning: The layout StructArrayLayout3ui6 is not aligned to 4-bytes boundaries. Warning: The layout StructArrayLayout1ui2 is not aligned to 4-bytes boundaries. * Exclude non-deterministic test from render tests harness This test is non-deterministic on AMD, slight offset in the pattern. Excluding until root cause can be identified on this hardware
* map.isMoving() match move events fix mapbox#9647 Previously isMoving() would return true if any interaction handler was active. Handlers are sometimes active even if they haven't changed the map yet. This resulted in the isMoving() returning true when the map hasn't moved. This makes isMoving aligned with movestart/move/moveend events. Since move events may be fired after several mouse events have been batched, the camera changes a mouseevent will *later* cause won't be reflected in isMoving() when that mouseevent is fired. * lint * fix test
* fix multi-finger gestures touching markers Previously we were using e.targetTouches as the list of touches relevant to the map. It contains only the touches that first touched the same target. Touches that hit a marker have a different target. This fixes uses e.touches and filters out touches who's target is not a child of the map. fix mapbox#9675 * update tests and add regression test
* set an interim paint in style_layer * add a simple test for undefined paint * Address review nits * Silence inconsistent flow error Co-authored-by: Nick Mann <nick_j_mann@uk.ibm.com>
* [release-danube] Changelog v1.10.1 (mapbox#9695) * v1.10.1 Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> * Suggestions from mapbox#9695 Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
* Style spec v13.15.0 Co-authored-by: Chloe Krawczyk <chloe.krawczyk@mapbox.com> Co-authored-by: Chloe Krawczyk <chloe.krawczyk@mapbox.com>
* fixes map.event:error link fixes https://github.com/mapbox/mapbox-gl-js-docs/issues/20 * replace markdown links with jsdoc link * fitbounds -> fitBounds
* kiraarghy:rotation-fix-iphone In response to issue mapbox#9639. 1. Added to map.js window.screen.orientation event listener for supporting browsers and fallback to deprecated 'orientationchange' event listener. (overkill but should ensure future compatibility) * Fixing to ensure the browser supports the latest version of the ScreenOrientation API * kiraarghy:rotation-fix-iphone 1. Add missed remove event listener * 1. Updated to use just 'orinetationchange' event listener
* avoid errors when requiring the browser bundle in Node * add a test for bundle evaluation in Node
…box#9758) visually in the style While mentioning the before/after order is important since it relates to the layers array, it requires users to know how the layers array order relates to visual layering on the map. By specifying both here we hope to avoid such confusion.
* Constrain camera height over terrain fixes
Constrain happens when camera moves but needs to happen also in steady mode: due to style or data loaded, camera could end up under or cutting terrain on near plane.
Constrain was so far based on max zoom (22), now based on actual camera zoom, alowing MAX_DRAPE_OVERZOOM = 2:
// Determine minimum height for the camera over the terrain related to current zoom.
// Values above than 2 allow max-pitch camera closer to e.g. top of the hill, exposing
// drape raster overscale artifacts or cut terrain (see under it) as it gets clipped on
// near plane.
Camera stays above ground when orbitting and it behaves the same way regardless the view zoom.
Fixes: internal-329, internal-97
* Rebase
* remove bundle transpilation to ES5 * remove IE11 main thread ajax hack * more buble cleanup * fix style spec test * try fixing bundle size check * add referrer hack back for old Safari * fix flow
* Fix sky demo using non supported date time feature Fix internal-353 * Lint
* Fix exception when using terrain with custom layer internal-349 * Add unit test * Lint
…rnal-358) * Retain child of faded tiles when used as LODs Fix internal-345, high pitch tiles not retaining child tiles while fading * Comment + renaming * Fixup
Address review comments, add details about functions and spec and remove v1.13 changes
Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
fix internal-372 512 raster tiles from the v4 API need to be requested using the '@2x' suffix.
* Adding some comments * Adding some comments
* robust buffer check * Add unit tests for prevPowerOfTwo * Fix height querying overflow when tileSize != returned image size
… Android devices (internal-376)
…379) Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com> Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com>
* Fix internal-373: LOD: application using traffic source blocks (3000+ tiles) when tilted A source which has min zoom of 6 - if tilting camera around zoom level 6 we try to return tiles of zoom 6 all the way to horizon, leading to 3000+ tile requests and performance hit.
* More style spec docs tweaks * Why cant I spell the correctly ever Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> * Update sky-atmosphere-color documentation Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com>
* Reflect new max pitch value in docs * Update more references of old pitch value
For locations behind the camera, set both components of their projected points to MAX_VALUE for consistency. It's not completely clear that this is a good approach.
… load. (internal-385) * first draft * post to gett * removing the comments and the headers * renaming * removing the access token * Fix Lint * Calling mapLoadEvent in Authenticate function * Cleanup the raster and vector files * Addressing PR comments * Adding code protection comment * Update src/ui/map.js Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> * combine 401 and missing mapbox access token Co-Authored-By: Sanaz Golbabaei <sanaz.golbabaei@gmail.com> * making the session path non-optional * Adding production changes * Fixing the unit test failure * Adding unit tests for mapbox.test.js * Fixing missing parameter for mapLoadEvent * Update warning text for v2 (internal-393) * Update src/ui/map.js Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> Co-authored-by: Arindam Bose <arindam.bose@mapbox.com> Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
# Conflicts: # README.md # src/source/vector_tile_worker_source.js # src/style-spec/rollup.config.js # src/style-spec/types.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog></changelog>