change pendingStepsRequest default queue size #16252
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://smartcontract-it.atlassian.net/browse/CAPPL-348
Reducing the pendingStepsRequest default queue size in engine.go accounts for 75% in the reduction in memory shown here, (which shoes a ~10 times reductions in memory usage)
https://docs.google.com/spreadsheets/d/1Hw9du-4K5obVLdrbso1nYKMQHDkbAvp8ulWq3wSkY64/edit?usp=sharing
The above results show that reducing the queue size from 100,000 to 1,000 does not have any impact on the workflow latency when running 200 workflows (in fact its a little better but not meaningfully so)