Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pendingStepsRequest default queue size #16252

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

ettec
Copy link
Collaborator

@ettec ettec commented Feb 6, 2025

Part of: https://smartcontract-it.atlassian.net/browse/CAPPL-348

Reducing the pendingStepsRequest default queue size in engine.go accounts for 75% in the reduction in memory shown here, (which shoes a ~10 times reductions in memory usage)

https://docs.google.com/spreadsheets/d/1Hw9du-4K5obVLdrbso1nYKMQHDkbAvp8ulWq3wSkY64/edit?usp=sharing

The above results show that reducing the queue size from 100,000 to 1,000 does not have any impact on the workflow latency when running 200 workflows (in fact its a little better but not meaningfully so)

@ettec ettec marked this pull request as ready for review February 6, 2025 13:22
@ettec ettec requested a review from a team as a code owner February 6, 2025 13:22
Copy link
Contributor

github-actions bot commented Feb 6, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

@krehermann krehermann self-requested a review February 6, 2025 15:37
@ettec ettec added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants