-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPA-1361]: feat(deployment/mcms): update common changesets #16249
base: ggoh/DPA-1367/test-helpers
Are you sure you want to change the base?
[DPA-1361]: feat(deployment/mcms): update common changesets #16249
Conversation
- Added new v2 version of set_config_mcms to support new MCMS library - Added new v2 version of transfer_to_mcms_with_timelock to support new MCMS library JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1361
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , GolangCI Lint (deployment) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. GolangCI Lint errors: Golang Lint (deployment)Source of Error:
Why: The linter found two issues: a suggestion to pre-allocate the Suggested fix: Pre-allocate the 2. Test failure: Core Tests (go_core_tests)Source of Error:
Why: The test Suggested fix: Investigate the logic in |
@@ -206,3 +210,75 @@ func SetConfigMCMS(e deployment.Environment, cfg MCMSConfig) (deployment.Changes | |||
|
|||
return deployment.ChangesetOutput{}, nil | |||
} | |||
|
|||
// SetConfigMCMSV2 is a reimplementation of SetConfigMCMS that uses the new MCMS library. | |||
func SetConfigMCMSV2(e deployment.Environment, cfg MCMSConfig) (deployment.ChangesetOutput, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay i didn know, happy to follow
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1361