Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few minor fix #1961

Merged
merged 9 commits into from
Jan 20, 2023
Merged

Few minor fix #1961

merged 9 commits into from
Jan 20, 2023

Conversation

fabienwnklr
Copy link
Contributor

  • Fix doc spelling error
  • Fix right click on option select it (i find this not useful and confusing for the debug phase)
  • Fix if text is empty but value not, set text as value

@risadams
Copy link
Contributor

This PR has conflicts with the main branch; I haven't pulled it yet to see what is conflicting, but would you please be able to resolve those and resubmit?

@fabienwnklr
Copy link
Contributor Author

sure, but i see no conflict ?
image

@risadams
Copy link
Contributor

odd.... I do??

image

@fabienwnklr
Copy link
Contributor Author

hum it's so weird lol, my fork is up to date..

image

@risadams risadams merged commit 6f07a5e into selectize:master Jan 20, 2023
@risadams
Copy link
Contributor

got it. it was only a problem with rebase, I was able to squash and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabienwnklr @risadams