Skip to content

3.6.4/issue/22692 unused import #22710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

som-snytt
Copy link
Contributor

Fixes #22692

If the explicit name is different from the symbol name, then it must have been a rename on import.

That is never satisfied by a wildcard selector.

@som-snytt som-snytt marked this pull request as ready for review March 5, 2025 01:51
@Gedochao Gedochao requested a review from KacperFKorban March 5, 2025 08:49
@Gedochao Gedochao requested a review from WojciechMazur March 5, 2025 08:49
@WojciechMazur
Copy link
Contributor

WojciechMazur commented Mar 5, 2025

Open CB stats

Scala Version Unused Warnings
3.6.3 1079
3.6.4-RC2 1191
3.6.4-RC2 + this PR 1194
3.6.4-RC2 + revert #22314 1070
3.7.0-RC1-bin-20250227-1b0be01-NIGHTLY 7378

So it seems like it fixes the linked issue, but at the same time the total amount of unused warnings has increased since 3.6.3.
Is it a good change? Hard to say without investigating them in the context of source code.

If anyone is instrested in the details warnings I've uploaded them as gists (it contains all warnings, not only Unused Warnings)
3.6.3 - https://gist.github.com/WojciechMazur/48ff0e124ae6862a8d139e5f7592b216
3.7-nightly - https://gist.github.com/WojciechMazur/c827f11d9f72ad67c9b79c4f39ee9f3b
3.6.4-RCs - https://gist.github.com/WojciechMazur/aadb545954190b81f7340f81dc79897e :

@som-snytt
Copy link
Contributor Author

I will take a look, understanding that it may not pay off. If it is a fool's errand, I'm the fool for it.

It may not be worth the uncertainty in any case, of course.

@WojciechMazur
Copy link
Contributor

WojciechMazur commented Mar 5, 2025

We've just discussed this topic internally and decided we'd release the 3.6.4-RC2 as 3.6.4 (final) without this change or revert of the PR that caused the regression in the RC3 release.
As the discussions proved the issue is non trivial to solve, each approach has it's own pros and cons

Thank you for investigating the issue and creating a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants