[3006.x] Ensure we raise an error when the name argument is invalid in pkgrepo.managed #65049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
reviewed
Aug 25, 2023
| with salt.utils.files.fopen(default_sources, "r") as fp: | ||
| pre_file_content = fp.read() | ||
|
|
||
| ret = _run() |
There was a problem hiding this comment.
If we only call _run() once why do we define this function and not call the actual functions instead?
s0undt3ch
approved these changes
Aug 25, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures we raise an error when the name passed to pkgrepo.managed for aptpkg is invalid
What issues does this PR fix or reference?
Fixes: #64451
Previous Behavior
It would actually copy a line from /etc/apt/sources.list to the file you defined in your state.
New Behavior
An error is raised letting the user know they need to properly define their repo name.