Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md to add a contribution guideline #238

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Update CONTRIBUTING.md to add a contribution guideline #238

merged 3 commits into from
Oct 8, 2023

Conversation

CodeMaster7000
Copy link
Contributor

This is a follow-up to issue #236 and creates a common, friendly ground so people can come to terms with how to commit to this repository.

@vercel
Copy link

vercel bot commented Oct 5, 2023

@CodeMaster7000 is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 6, 2023

LGTM

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 6, 2023

@CodeMaster7000
Copy link
Contributor Author

CodeMaster7000 commented Oct 6, 2023

@ryo-ma There appears to be a formatting issue.

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 6, 2023

yes, I know that.
you should run the deno fmt

@CodeMaster7000
Copy link
Contributor Author

@ryo-ma I have and it gives some additions and deletions - I'm not sure what to do.

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 6, 2023

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 7, 2023

I probably can't because this branch is your forked repository.

Did you rebase? If you don't understand that, you should study Github and Git thoroughly.

@ryo-ma
Copy link
Owner

ryo-ma commented Oct 7, 2023

I'm not in a hurry so I'll wait.
I'm not going to commit it to your repository.

If you do not fix it, I will close this PR and commit directly to my master branch. This method is the least labor-intensive for me.

@CodeMaster7000
Copy link
Contributor Author

@ryo-ma I believe the conflicts have been resolved now. I will now address the fmt. I am new to this so please request changes if I made an error somewhere.

Thank you so much for your patience.

@ryo-ma ryo-ma merged commit 866cdcc into ryo-ma:master Oct 8, 2023
@ryo-ma
Copy link
Owner

ryo-ma commented Oct 8, 2023

LGTM

@CodeMaster7000 CodeMaster7000 deleted the patch-1 branch October 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants