Skip to content

create documentation of button component #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

enieber
Copy link
Contributor

@enieber enieber commented Jun 7, 2021

documentation of button component based in the doc of react-native with samples

@enieber enieber mentioned this pull request Jun 7, 2021
20 tasks
Copy link
Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not just copy the page from RN website, this adds no value. We should instead focus on what is different from there docs.

docs/button.md Outdated

A basic button component that should render nicely on any platform. Supports a minimal level of customization.

If this button doesn't look right for your app, you can build your own button using [TouchableOpacity](touchableopacity) or [TouchableWithoutFeedback](touchablewithoutfeedback).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressable are recommended instead of Touchables.

docs/button.md Outdated

## Example

```SnackPlayer name=Button%20Example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snack don't works on our website and can't.
Maybe a simple example without other component could be nice for a start, like for Text.

docs/button.md Outdated

| Type |
| ---------------------------------- |
| function([PressEvent](pressevent)) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link don't work.

docs/button.md Outdated

## Props

### <div class="label required basic">Required</div>**`onPress`**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this css things doesn't work am I right?

@enieber enieber requested a review from MoOx June 7, 2021 07:43
@MoOx
Copy link
Member

MoOx commented Oct 5, 2022

@davisuga feel free to take this and address issue I mentioned :)

@enieber enieber closed this Nov 4, 2022
@enieber enieber deleted the patch-2 branch November 4, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants