Add context menu to update source attachment for the binary classfile #699
+90
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
|
This PR will only support selecting a jar/zip file as new source, and use the default OS encoding to parse attachment. I feel like folder and encoding support is a low priority, so don't support selecting a folder and changing the attachment encoding format yet, how do you think? |
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
|
I have a separate POC to set source encoding, I need to share. For now we'll keep it simple |
fbricon
reviewed
Oct 31, 2018
package.json
Outdated
| }, | ||
| { | ||
| "command": "java.project.updateSourceAttachment", | ||
| "when": "false == true" |
There was a problem hiding this comment.
i'm stupid. Use false instead. The purpose is to stop the command showing in the command palette.
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
It fixes the bug #233 (Add ability to attach missing source). This PR will enable the context menu
Update Source Attachmenton the jdt content provider. See the peer PR on eclipse.jdt.ls eclipse-jdtls/eclipse.jdt.ls#837