Add PreStop configuration option #3170
Open
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayshah
changed the title
dayshah
commented
Mar 10, 2025
| @@ -1095,6 +1098,9 @@ func (r *RayClusterReconciler) buildHeadPod(ctx context.Context, instance rayv1. | |||
| if len(r.headSidecarContainers) > 0 { | |||
| podConf.Spec.Containers = append(podConf.Spec.Containers, r.headSidecarContainers...) | |||
| } | |||
| if r.PreStopCommand != "" { | |||
| podConf.Spec.Containers[utils.RayContainerIndex].Lifecycle = createPreStopLifecycle(r.PreStopCommand) | |||
There was a problem hiding this comment.
Do I have to check if there's already a lifecycle assigned here, or if there's some prestop / poststart commands already assigned that I have to add to? Or is it ok to assume there will no be lifecycle for this container at this point?
There was a problem hiding this comment.
yes I think we should check and only set it if not set by the user
|
I will wait for @andrewsykim to review this PR since he is a user of this API. I will perform a final review later. |
|
@dayshah would you mind fixing the CI errors https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md? |
Signed-off-by: dayshah <dhyey2019@gmail.com>
Signed-off-by: dayshah <dhyey2019@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Gives users an option to add a prestop hook which will drain the ray node when it's triggered.
Related issue number
#3185
Checks