Reduce repeated calls to node name and type #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to help with #122
In the main loop we may call
node.name
andnode.node_type
several times in differentif
statement.node.name
in particular results in allocation of a string, boosting memory usage. Calling them once and storing them locally reduces memory use.In a test reading 10k (mostly empty) rows from a spreadsheet can see that the extra allocations from calling
node.name
in later branches of the if disappear from the stats. Overall %age reduction in allocations is small (~2% in this case), so won't fix the memory usage but will help. %age reduction may be larger for sheets that contain more cells, as the later branches will be exercised more often.