-
Notifications
You must be signed in to change notification settings - Fork 49
Support for running tests against Heimdal in CI #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c5b1d60
to
f04f967
Compare
f04f967
to
3d1244b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several "if not heimdal" or "if not darwin" checks - are you intentionally assuming that macOS implies distro heimdal? It's tricky because I think there are three different GSSAPIs one could be using on macOS. I also don't know whether this is worth caring about.
Additional thoughts inline.
3d1244b
to
1bb99bf
Compare
Somewhat, as you have said someone could have MIT Kerberos, GSS.framework Heimdal, or pure Heimdal installed on macOS so there's no easy way to detect this. I could reuse
Thanks, the changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Jordan Borean <jborean93@gmail.com>
1bb99bf
to
a253964
Compare
This requires pythongssapi/k5test#13 to be reviewed/merged/released first as currently it is installing straight from source to verify the tests do in fact work. Once that is done the lines https://github.com/pythongssapi/python-gssapi/pull/262/files#diff-0466ec3bdb3913aba71d897f97c298a0de3f922e14fe75af374e16e8478104c3R111-R114 can be removed from this PR.I initially looked at running these tests on Windows as well but it doesn't look like MIT Kerberos on Windows provides a kdc service so I dropped that idea.
Should fix #233 - at least combined with the k5test PR.