GH-98831: Remove all remaining DISPATCH() calls from bytecodes.c #99271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also mark those opcodes that have no stack effect as such.
|
@brandtbucher When you have the benchmark results can you just post them here? So Mark won't have to ask for them. |
|
Here you go: |
markshannon
reviewed
Nov 10, 2022
| /* Use BASIC_PUSH as NULL is not a valid object pointer */ | ||
| BASIC_PUSH(NULL); | ||
| inst(PUSH_NULL, (-- res)) { | ||
| res = NULL; |
There was a problem hiding this comment.
I feel that this ought to fail, as we should have NULL checks in debug mode.
There was a problem hiding this comment.
Yeah, but we never had those. In debug mode we check for stack overflow/underflow but not for NULL-ness. (Of course the NULL will wreak havoc if it gets popped by the wrong opcode, bu that's also nothing new.) The code generator still checks for stack over/underflow by calling STACK_SHRINK()/GROW(), so nothing is really changed.
There was a problem hiding this comment.
Once we have typed stack effects, we can auto-generate those sorts of assertions. That would be really nice.
brandtbucher
approved these changes
Nov 10, 2022
| @@ -2642,14 +2631,15 @@ dummy_func( | |||
| PyObject *next = PyList_GET_ITEM(seq, it->it_index++); | |||
| PUSH(Py_NewRef(next)); | |||
| JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER); | |||
| DISPATCH(); | |||
| goto end_for_iter_list; // End of this instruction | |||
There was a problem hiding this comment.
Yeah, I'm really counting on the compiler to optimize this for us.
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
gvanrossum
added a commit
to gvanrossum/cpython
that referenced
this pull request
Nov 10, 2022
python#99271) Also mark those opcodes that have no stack effect as such. Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
ethanfurman
pushed a commit
to ethanfurman/cpython
that referenced
this pull request
Nov 12, 2022
python#99271) Also mark those opcodes that have no stack effect as such. Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also mark those opcodes that have no stack effect as such (
inst(FOO)->inst(FOO, (--))).