Skip to content

GH-106895: Raise a ValueError when attempting to disable events that cannot be disabled. #107337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jul 27, 2023

@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c6539b36c163efff3d6ed02b938a6151325f4db7 3.12

@bedevere-bot
Copy link

GH-107351 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 27, 2023
markshannon added a commit to faster-cpython/cpython that referenced this pull request Jul 27, 2023
markshannon added a commit that referenced this pull request Jul 28, 2023
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.12 has failed when building commit 0902afb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1159/builds/233) and take a look at the build logs.
  4. Check if the failure is related to this commit (0902afb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1159/builds/233

Failed tests:

  • test_concurrent_futures

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

432 tests OK.

10 slowest tests:

  • test_math: 4 min 37 sec
  • test_multiprocessing_spawn: 4 min 34 sec
  • test_wmi: 3 min 44 sec
  • test_capi: 2 min 51 sec
  • test_unparse: 2 min 50 sec
  • test_peg_generator: 2 min 27 sec
  • test_tokenize: 2 min 11 sec
  • test_lib2to3: 1 min 55 sec
  • test_mmap: 1 min 29 sec
  • test_pickle: 1 min 27 sec

35 tests skipped:
test.test_asyncio.test_unix_events test_curses test_dbm_gnu
test_dbm_ndbm test_devpoll test_epoll test_fcntl test_fork1
test_gdb test_grp test_ioctl test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_nis test_openpty
test_ossaudiodev test_perf_profiler test_perfmaps test_pipes
test_poll test_posix test_pty test_pwd test_readline test_resource
test_spwd test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64 test_zoneinfo

1 re-run test:
test_concurrent_futures

Total duration: 29 min 36 sec

Click to see traceback logs
Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 480, in temp_dir
    yield path
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\os_helper.py", line 533, in temp_cwd
    yield cwd_dir
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 758, in main
    self._main(tests, kwargs)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 817, in _main
    sys.exit(0)
SystemExit: 0


Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\support\__init__.py", line 207, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\buildarea\\3.12.bolen-windows10\\build\\build\\test_python_9400�\\test_python_worker_9496�'


Traceback (most recent call last):
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\__main__.py", line 2, in <module>
    main()
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 822, in main
    Regrtest().main(tests=tests, **kwargs)
  File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\main.py", line 752, in main

@markshannon markshannon deleted the raise-on-disable branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants