-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-101277: Isolate itertools, add group and _grouper types to module state #101302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101277: Isolate itertools, add group and _grouper types to module state #101302
Conversation
This is part 1 of 4. I've split each PR so the diffs are ~200 lines of code, excluding clinic changes. This PR add helpers for fetching state, adds tests for type immutability, converts two of the types to heap types, and add them to the module state. Follow-up PRs for the rest of the types are created as draft PRs; these will be rebased onto The last PR will purge the global-to-fix file, and add a NEWS entry. |
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 6dc2032 🤖 If you want to schedule another build, you need to add the |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews! Highly appreciated. I'm considering landing this tomorrow. |
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
I'm landing this shortly. I'll rebase #101303 onto Thanks again for the reviews. |
* main: pythongh-98831: rewrite PUSH_EXC_INFO and conditional jumps in the instruction definition DSL (python#101481) pythongh-98831: Modernize the LOAD_ATTR family (python#101488) pythongh-101498 : Fix asyncio.Timeout example in docs (python#101499) pythongh-101454: fix documentation for END_ASYNC_FOR (python#101455) pythongh-101277: Isolate itertools, add group and _grouper types to module state (python#101302) pythongh-101317: Add `ssl_shutdown_timeout` parameter for `asyncio.StreamWriter.start_tls` (python#101335) datetime.rst: fix combine() signature (python#101490)
Part 1/4