gh-81057: Move Threading-Related Globals to _PyRuntimeState #100084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericsnowcurrently
commented
Dec 7, 2022
•
ericsnowcurrently
commented
- Issue: [subinterpreters] Global C variables are a problem #81057
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ericsnowcurrently
force-pushed
the
consolidate-threading-globals
branch
from
f2399f9 to
f05396b
Compare
|
How about changing the thread initializer |
|
It's called when the GIL is created, which is already a part of initializing the main interpreter. Perhaps I misunderstood what you meant? |
ericsnowcurrently
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit f05396b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
ericsnowcurrently
force-pushed
the
consolidate-threading-globals
branch
from
f05396b to
3c22543
Compare
|
This change broke the wasm32-wasi 3.x buildbot: https://buildbot.python.org/all/#/builders/1046/builds/1051 |
|
I'll look into it. |
ericsnowcurrently
added a commit
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.