Skip to content

Minor improvements to "generated interpreter" change #99104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nascheme opened this issue Nov 4, 2022 · 0 comments
Closed

Minor improvements to "generated interpreter" change #99104

nascheme opened this issue Nov 4, 2022 · 0 comments
Assignees
@gvanrossum
Labels
easy type-feature A feature request or enhancement

Comments

@nascheme
Copy link
Member

nascheme commented Nov 4, 2022 •
edited by bedevere-bot
Loading

A couple small nits for the generated interpreter change:

  • Python/generated_cases.c.h should point to the script folder in Tools (path is out-of-date).
  • Python/bytecodes.c file should have a comment at the top pointing to Tools/cases_generator/README.md.
@nascheme nascheme added type-feature A feature request or enhancement easy labels Nov 4, 2022
@bedevere-bot bedevere-bot mentioned this issue Nov 4, 2022
Merged
gvanrossum added a commit that referenced this issue Nov 5, 2022
@gvanrossum
GH-99104: Update headers for bytecodes.c and generate_cases.py (#99112)
d04899a 
Also tweak the labels near the end of bytecodes.c.
@nascheme nascheme closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvanrossum gvanrossum

Labels
easy type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nascheme @gvanrossum