Skip to content

[pre-commit.ci] pre-commit autoupdate #8873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

Conversation

pre-commit-ci bot and others added 3 commits April 7, 2025 17:17
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.9 → v0.11.4](astral-sh/ruff-pre-commit@v0.9.9...v0.11.4)
- [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0)
- [github.com/python-jsonschema/check-jsonschema: 0.31.2 → 0.32.1](python-jsonschema/check-jsonschema@0.31.2...0.32.1)
- [github.com/woodruffw/zizmor-pre-commit: v1.4.1 → v1.5.2](woodruffw/zizmor-pre-commit@v1.4.1...v1.5.2)
- [github.com/abravalheri/validate-pyproject: v0.23 → v0.24.1](abravalheri/validate-pyproject@v0.23...v0.24.1)
@hugovk
Copy link
Member

hugovk commented Apr 7, 2025

New clang-format gave this error before, removing Language: Cpp from the config:

clang-format.............................................................Failed
- hook id: clang-format
- exit code: 1

Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format
Configuration file(s) do(es) not support C: /home/runner/work/Pillow/Pillow/.clang-format

https://github.com/python-pillow/Pillow/actions/runs/14315399800/job/40120258457?pr=8873

@radarhere
Copy link
Member

Investigating, I think clang is detecting some files as C++, and some as C.

Looking at https://clang.llvm.org/docs/ClangFormatStyleOptions.html#clang-format-style-options, I think a way to specify both languages would be to list the options twice - radarhere@8b7d724 - but you might think that is unsightly.

@hugovk
Copy link
Member

hugovk commented Apr 8, 2025

If there's no way to force it to check as C, then that's fine by me, we don't need to change it too often.

@radarhere
Copy link
Member

https://clang.llvm.org/docs/ClangFormatStyleOptions.html#language

You can specify the language (C, Cpp, or ObjC) for .h files by adding a // clang-format Language: line before the first non-comment (and non-empty) line, e.g. // clang-format Language: Cpp.

So radarhere@05dea18 is another option.

@hugovk
Copy link
Member

hugovk commented Apr 8, 2025

Either fine with me :)

Copy link
Member

@radarhere radarhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've listed the options twice.

@hugovk hugovk merged commit 5b1a64c into main Apr 10, 2025
136 of 177 checks passed
@radarhere radarhere deleted the pre-commit-ci-update-config branch April 10, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants