Correct path in nested models #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 2157 2160 +3
Branches 426 427 +1
=====================================
+ Hits 2157 2160 +3 |
tests/test_error_wrappers.py
Outdated
|
|
||
| def test_nested_error(): | ||
| class NestedModel1(BaseModel): | ||
| class NestedModel2(BaseModel): |
There was a problem hiding this comment.
this a bit confusing, no need to nest the class definitions, just
class NestedModel3(BaseModel):
x: str
class NestedModel2(BaseModel):
data2: List[NestedModel3]
class NestedModel1(BaseModel):
data1: List[NestedModel2]
HISTORY.rst
Outdated
| @@ -7,6 +7,7 @@ v0.21.1 (unreleased) | |||
| .................... | |||
| * add ``IPv{4,6,Any}Network`` and ``IPv{4,6,Any}Interface`` types from ``ipaddress`` stdlib, #333 by @pilosus | |||
| * add docs for ``datetime`` types, #386 by @pilosus | |||
| * fix path in nested models, by @kataev | |||
There was a problem hiding this comment.
please add PR number here as per other entries.
There was a problem hiding this comment.
also will need resolve conflicts.
|
Well, what next? |
|
Awesome, thank you very much. I'll try and wait for #428 to deploy, but if that takes a long time I'll deploy this in a few days. Hope that's okay. |
|
Yep, no problem. |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i find what first part of path is missed on errors in nested models.
Here the fix and tests.