Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an info page bug #393

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Fix an info page bug #393

merged 2 commits into from
Feb 28, 2021

Conversation

KrahJohlito
Copy link
Member

@KrahJohlito KrahJohlito commented Feb 21, 2021 •
edited
Loading

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

Currently there seem to be multiple bugs related to scrolling through games while on the info page, this fixes one of the bugs. Only down side is that since the keys are translated at init rather than draw; if the language is changed the theme needs to be reloaded in order to translate the strings.

If this gets merged it would be good to also merge into 1.0 since the bug is present there and would be easier to check (I don’t have legacy toolchain atm) if the remaining bug is related to toolchain changes (probably not though).

@uyjulian uyjulian merged commit a8c7163 into ps2homebrew:master Feb 28, 2021
@KrahJohlito KrahJohlito deleted the patch branch March 8, 2021 06:26
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
@uyjulian
Merge pull request #393 from KrahJohlito/patch
8eda912 
Fix an info page bug
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
4c72dd8 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
dd647b5 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
00087fb 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
bbef59b 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
cae49a5 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
d859d74 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
bc7d9a3 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 10, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
82fcc74 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 11, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
596d9f0 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 11, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
2280457 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 11, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
4bb14c5 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
7beaf03 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
7d7a9d2 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
a0970be 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
5f04c4e 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
ecdd5bb 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
ac2a3ff 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
fcb0a6a 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
4f9809f 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
5607909 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
8e1a9a2 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
da3a42b 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 13, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
2be8621 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
e0046f4 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
bdb683f 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
c6a63cf 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
5d83740 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
faef4c4 
Fix an info page bug
AKuHAK pushed a commit to AKuHAK/Open-PS2-Loader that referenced this pull request Mar 14, 2025
@uyjulian
Merge pull request ps2homebrew#393 from KrahJohlito/patch
9fbfeaf 
Fix an info page bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrahJohlito @uyjulian