Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] more precise regex for renovate images detection #5461

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

jkroepke
Copy link
Member

What this PR does / why we need it

this should fix wrong image detection on prometheus helm chart.

Old regex: https://regex101.com/r/VileVj/1

Ref:

# sidecarContainers - add more containers to prometheus server
# Key/Value where Key is the sidecar `- name: <Key>`
# Example:
# sidecarContainers:
# webserver:
# image: nginx
# OR for adding OAuth authentication to Prometheus
# sidecarContainers:
# oauth-proxy:
# image: quay.io/oauth2-proxy/oauth2-proxy:v7.1.2
# args:
# - --upstream=http://127.0.0.1:9090
# - --http-address=0.0.0.0:8081
# - ...
# ports:
# - containerPort: 8081
# name: oauth-proxy
# protocol: TCP
# resources: {}
sidecarContainers: {}

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested review from GMartinez-Sisti and a team as code owners March 20, 2025 18:49
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@GMartinez-Sisti
Copy link
Member

DCO missing 😝

@jkroepke jkroepke merged commit 1251b01 into main Mar 21, 2025
4 checks passed
@jkroepke jkroepke deleted the jkroepke-patch-1 branch March 21, 2025 15:29
szibis pushed a commit to szibis/prometheus-helm-charts that referenced this pull request Mar 22, 2025
…munity#5461)

* [ci] more precise regex for images detection

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* Update renovate.json

Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Signed-off-by: Slawomir Skowron <329831+szibis@users.noreply.github.com>
jenrik pushed a commit to jenrik/prometheus-community-helm-charts that referenced this pull request Mar 24, 2025
…munity#5461)

* [ci] more precise regex for images detection

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

* Update renovate.json

Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>

---------

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants