Break TCPConnection's _read_buffer_size into 3 different variables #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, _read_buffer_size was used for 3 different purposes: - Sizing the read buffer - Controlling how many bytes to read before yielding the CPU - Controlling how many bytes to write before yielding the CPU This commit provides 3 different variables, one for each of the 3 possible usages. Closes #3186
mfelsche
approved these changes
Jun 18, 2019
patches11
pushed a commit
to patches11/ponyc
that referenced
this pull request
Jun 29, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, _read_buffer_size was used for 3 different
purposes:
This commit provides 3 different variables, one for each of the 3
possible usages.
Closes #3186