Fix LLVM IR verification with DoNotOptimise #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this so we can prevent regressions? |
This change fixes a bug where an incorrect attribute was being generated on primitive types used with DoNotOptimise. Closes ponylang#2493.
|
Test added. |
|
TravisCI MacOS is completely behind. I cancelled the MacOS jobs there and tested locally. |
SeanTAllen
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Jan 20, 2018
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where an incorrect attribute was being generated on primitive types used with
DoNotOptimise.Closes #2493.