Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LLVM 3.7.1 and 3.8.1 support #2461

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Deprecate LLVM 3.7.1 and 3.8.1 support #2461

merged 1 commit into from
Jan 4, 2018

Conversation

SeanTAllen
Copy link
Member

On the most recent sync call we decided to only officially support LLVM
3.9.1. Additionally we are maintaing CI for our experimentally supported
LLVM 4 and 5 work. The goal is to get LLVM 4 and 5 issues fixed so they
are no longer experimental.

Closes #2063

chalcolith
chalcolith reviewed Jan 3, 2018
View reviewed changes
Copy link
Member

@chalcolith chalcolith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could update wscript as well:

@@ -43,8 +43,6 @@ MSVC_VERSIONS = [ '15.4', '15.0', '14.0' ]
 # keep these in sync with the list in .appveyor.yml
 LLVM_VERSIONS = [
     '3.9.1',
-    '3.8.1',
-    '3.7.1',
     '5.0.0',
     '4.0.1'
 ]

@SeanTAllen
Deprecate LLVM 3.7 and 3.8
33bcf80 
On the most recent sync call we decided to only officially support LLVM
3.9.1. Additionally we are maintaing CI for our experimentally supported
LLVM 4 and 5 work. The goal is to get LLVM 4 and 5 issues fixed so they
are no longer experimental.

Closes #2063
@SeanTAllen SeanTAllen force-pushed the deprecate-llvm-37-38 branch from 1352c31 to 33bcf80 Compare January 4, 2018 00:27
@SeanTAllen
Copy link
Member Author

@kulibali updated.

@SeanTAllen
Copy link
Member Author

@jemc you weren't at the part of sync where we agreed to drop 3.8.1, want to get your sign off before we move forward with this.

@SeanTAllen
Copy link
Member Author

@jemc gave his verbal approval to me for this.

@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Jan 4, 2018
@SeanTAllen SeanTAllen mentioned this pull request Jan 4, 2018
Closed
@SeanTAllen SeanTAllen changed the title Deprecate LLVM 3.7 and 3.8 Deprecate LLVM 3.7.1 and 3.8.1 Jan 4, 2018
@SeanTAllen SeanTAllen changed the title Deprecate LLVM 3.7.1 and 3.8.1 Deprecate LLVM 3.7.1 and 3.8.1 support Jan 4, 2018
@SeanTAllen SeanTAllen merged commit 0447816 into master Jan 4, 2018
@SeanTAllen SeanTAllen deleted the deprecate-llvm-37-38 branch January 4, 2018 02:51
ponylang-main added a commit that referenced this pull request Jan 4, 2018
@ponylang-main
Update CHANGELOG for PR #2461 [skip ci]
0afe5e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalcolith chalcolith chalcolith approved these changes

@jemc jemc jemc approved these changes

@Praetonus Praetonus Awaiting requested review from Praetonus

Assignees
No one assigned
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing LLVM 3.7 support
3 participants
@SeanTAllen @chalcolith @jemc