Garbage collect actors when --ponynoblock is in use #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
changed the title
SeanTAllen
added
the
changelog - fixed
Prior to this commit, actors wouldn't be garbage collected when using --ponynoblock. With this change, any actors that aren't part of a cycle will be garbage collected if they can no longer do work. Before this change, using `--ponynoblock` with an application that created transient actors would result in never ending memory growth as the actors would never be gc'd. You can see an example of this by taking a Pony program that listens for TCP connections and do a repeating cycle of open/close. None of the created `TCPConnection` actors would be garbage collected. Closes #2306
SeanTAllen
force-pushed
the
gc-actors-with-ponynoblock
branch
from
c8129a9 to
7c0ba75
Compare
|
One OSX CI build failed on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, actors wouldn't be garbage collected when using
--ponynoblock. With this change, any actors that aren't part of a cycle
will be garbage collected if they can no longer do work.
Before this change, using
--ponynoblockwith an application thatcreated transient actors would result in never ending memory growth as
the actors would never be gc'd. You can see an example of this by taking
a Pony program that listens for TCP connections and do a repeating cycle
of open/close. None of the created
TCPConnectionactors would begarbage collected.
Closes #2306