Fix handling of empty and multi-byte character literals #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The build failure looks unrelated, I've restarted it for good measure. |
Praetonus
added
the
changelog - fixed
jemc
changed the title
ponylang-main
added a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will treat empty character literals as invalid syntax
and handle weird utf8 character literals like
'🎠'correctly.The root cause was the casting from
chartointwhich created ints like0xFFFFFF9Ffor a lexer char\x9F. This was treated as negative and thus ignored by the lexer.This fixes #2198 in that it treats multi-byte input correctly byte by byte.