Properly account for foreign objects in GC #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, foreign objects were accounted for upon receive but then their impact on the heap was lost whenever GC ran. This commit resolves that by making sure that foreign objects are properly accounted in the heap during the marking phase of GC in a manner similar to how they're accounted for upon receive. Resolves ponylang#1550
|
@sylvanc can you verify this is as you intended? |
SeanTAllen
added
the
triggers release
|
Is it possible this also solves #1781? |
|
Upon a quick look, I'm not sure that this change would solve issue #1781. It would need to be tested explicitly to confirm. |
|
My understanding of this PR is that it fixes the heuristics for when to trigger GC, so it probably doesn't fix #1781. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, foreign objects were accounted for upon
receive but then their impact on the heap was lost whenever GC
ran. This commit resolves that by making sure that foreign objects
are properly accounted in the heap during the marking phase of GC
in a manner similar to how they're accounted for upon receive.
Resolves #1550