Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved persistent map api (RFC 36) #1705

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Improved persistent map api (RFC 36) #1705

merged 1 commit into from
Mar 17, 2017

Conversation

Theodus
Copy link
Contributor

@Theodus Theodus commented Mar 16, 2017 •
edited
Loading

The tests for the collections/persistent package are also cleaned up a bit to be consistent with other packages.

Closes #1692

@SeanTAllen
Copy link
Member

Your error @Theodus:

Error:
/home/travis/build/ponylang/ponyc/packages/stdlib/_test.pony:60:32: couldn't find 'make' in 'Main'
    collections_persistent.Main.make().tests(test)

jemc
jemc reviewed Mar 16, 2017
View reviewed changes
packages/collections/persistent/_test.pony Outdated

let l2 = Lists[U32].empty()
h.assert_error({()? => l2(0) })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we have formally established a stdlib style for these yet, but I prefer to see this space before the end of the lambda body remain, as it mirrors the space that comes before the lambda body (after the fat arrow).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At any rate, if we wanted to change the style here after discussing it, we should probably do it globally for the whole stdlib, and in a separate PR dedicated to that change.

@Theodus
Copy link
Contributor Author

Theodus commented Mar 16, 2017

@SeanTAllen The error has been corrected.
@jemc I have put the spaces back into the ends of the lambda expressions.

@Theodus Theodus changed the title Implement RFC 36 Improved persistent map api (RFC 36) Mar 16, 2017
@Theodus Theodus added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Mar 16, 2017
@SeanTAllen SeanTAllen merged commit 32ea53c into ponylang:master Mar 17, 2017
ponylang-main added a commit that referenced this pull request Mar 17, 2017
@ponylang-main
Update CHANGELOG for PR #1705 [skip ci]
430a105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Theodus @SeanTAllen @jemc