Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent blank InAppBrowser Activity from being restored #1984

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Prevent blank InAppBrowser Activity from being restored #1984

merged 1 commit into from
Oct 25, 2024

Conversation

ShuheiSuzuki-07
Copy link

@ShuheiSuzuki-07 ShuheiSuzuki-07 commented Jan 18, 2024 •
edited
Loading

@pichillilorenzo

Connection with issue(s)

Resolve issue #1983

Connected to #1983

Testing and Review Notes

  1. launch the example application and open InAPpBrowser
  2. kill the process depending on the OS (can be achieved by changing permissions)
  3. start the example app again MainActivity is restarted and operation is possible (InAppBrowser is closed)

Screenshots or Videos

After this PR marged:
output2

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

Best Regards,

@ShuheiSuzuki-07 ShuheiSuzuki-07 marked this pull request as ready for review January 18, 2024 06:46
@ShuheiSuzuki-07 ShuheiSuzuki-07 mentioned this pull request Oct 2, 2024
Closed
2 tasks
@pichillilorenzo pichillilorenzo merged commit 53f627f into pichillilorenzo:master Oct 25, 2024
@pichillilorenzo pichillilorenzo changed the title issue #1983: Fixed to prevent Activity from being restored issue #1983: Fixed to prevent InAppBrowser Activity from being restored Oct 25, 2024
This was referenced Oct 25, 2024
Closed
Merged
Repository owner deleted a comment from allcontributors bot Oct 25, 2024
Repository owner deleted a comment from allcontributors bot Oct 25, 2024
@pichillilorenzo
Copy link
Owner

@all-contributors please add @ShuheiSuzuki-07 for code

@allcontributors AllContributors
Copy link
Contributor

@pichillilorenzo

@ShuheiSuzuki-07 already contributed before to code

@pichillilorenzo pichillilorenzo changed the title issue #1983: Fixed to prevent InAppBrowser Activity from being restored issue #1983: Fixed to prevent blank InAppBrowser Activity from being restored Oct 25, 2024
@pichillilorenzo pichillilorenzo changed the title issue #1983: Fixed to prevent blank InAppBrowser Activity from being restored Prevent blank InAppBrowser Activity from being restored Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShuheiSuzuki-07 @pichillilorenzo @shuhei-suzuki-07