Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android imm.isAcceptingText() crash fix #1827

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

AlexDochioiu
Copy link
Contributor

I see some isolated cases where isAcceptingText crashes, killing the entire app. Added a small safety net to avoid this.

P.s. This was fully reproducible for one user (Huawei P30 light - Android 10) when accessing app.dexhunter.io.

image

@pichillilorenzo
Copy link
Owner

The Fixed canGoForward NPE commit should be made in a separate pull request.
By the way, I think that the null pointer exception on canGoForward is caused by the usage of the webview controller after the webview as been disposed.
Probably, I should throw an exception if someone tries to call any controller method after the webview is disposed, because the internal _channel will be null.

@pichillilorenzo pichillilorenzo changed the title imm crash fix android imm.isAcceptingText() crash fix Nov 10, 2023
@pichillilorenzo pichillilorenzo merged commit fb7e025 into pichillilorenzo:master Nov 10, 2023
@pichillilorenzo
Copy link
Owner

@all-contributors please add @AlexDochioiu for code

Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @AlexDochioiu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants