Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Upgrade libv8 dependency to 6.3 branch #45

Closed
5 tasks done
pinepain opened this issue Sep 2, 2017 · 1 comment
Closed
5 tasks done

Upgrade libv8 dependency to 6.3 branch #45

pinepain opened this issue Sep 2, 2017 · 1 comment
Assignees
Milestone

Comments

@pinepain
Copy link
Member

pinepain commented Sep 2, 2017

v8 6.3 is out and as we stick to the latest v8 version, it's time.

There is also change in late 6.2 (Pass Isolate pointer to String::Utf8Value/Value constructors v8/v8@fe59853 in 6.2.396) we might benefit from and as 6.3 is out there is no major reason against upgrading libv8 dependency.

  • release libv8-6.3 to PPA
  • release v8@6.3 to homebrew tap
  • update php-v8 deb build and runtime requirements
  • update php-v8 PPA dependency to include libv8-6.3 PPA
  • update php-v8 build requirements (config.m4, .travis.yml, CMakeLists.txt, provision)
@pinepain pinepain added this to the 0.2.0 milestone Sep 2, 2017
@pinepain pinepain added the v8:api label Sep 2, 2017
@pinepain pinepain self-assigned this Sep 2, 2017
pinepain added a commit that referenced this issue Sep 2, 2017
pinepain added a commit that referenced this issue Sep 2, 2017
@pinepain
Copy link
Member Author

pinepain commented Sep 3, 2017

After updating some tests become red and reports leaks - https://travis-ci.org/pinepain/php-v8/jobs/271257124. I'm not sure was there any changes in v8 internals that affects userland code and thus need some adjustmets or it's a v8 internals issue or it just false-positive. Filled a report to v8-users mail lists - https://groups.google.com/forum/#!topic/v8-users/qu1HrjbgRsg.

Moving this into separate issue #47.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant