Skip to content

[monitoring] Add support of Datadog #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

uro
Copy link
Contributor

@uro uro commented Jan 4, 2019

Pull request for issue #714

I skipped unit tests of Datadog integration, I think there's nothing to test.

  • Implement the integration
  • Confirm that it works properly with Datadog
  • Confirm that the logic has sense and it's usable for monitoring purposes

@uro
Copy link
Contributor Author

uro commented Jan 8, 2019

Hey @makasim
I confirm that integration works and it's usable from data point of view.

All of the metrics are visible by datadog:
screenshot 2019-01-08 at 15 14 34

I've build simple dashboard to check if metric types and values works well. For now it satisfying me.
screenshot 2019-01-08 at 15 14 05

Can you please review this pr?

@makasim
Copy link
Member

makasim commented Jan 8, 2019

This looks awesome!

Could you please add some doc?

and register it here https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/monitoring/Resources.php#L30

@uro
Copy link
Contributor Author

uro commented Jan 8, 2019

Documentation added 👍
https://github.com/uro/enqueue-dev/blob/feature/174-monitoring-datadog-support/docs/monitoring.md#datadog-storage

And as I see, it's already registered in resources.

Feel free to merge :)

@uro uro changed the title [WIP][monitoring] Add support of Datadog [monitoring] Add support of Datadog Jan 8, 2019
@uro
Copy link
Contributor Author

uro commented Jan 9, 2019

@makasim I don't understand why build has failed, I didn't touch stomp or anything. Should I do anything more?

@makasim makasim merged commit 01787a0 into php-enqueue:master Jan 9, 2019
@uro uro deleted the feature/174-monitoring-datadog-support branch January 9, 2019 12:12
@makasim
Copy link
Member

makasim commented Jan 9, 2019

available since 0.9.6

@makasim
Copy link
Member

makasim commented Jan 9, 2019

as for tests, it is not your fault, it fails from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants