Skip to content

[client] Move client config to the factory. #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions pkg/enqueue-bundle/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Enqueue\Bundle\DependencyInjection;

use Enqueue\Client\RouterProcessor;
use Enqueue\Symfony\Client\DependencyInjection\ClientFactory;
use Enqueue\Symfony\DependencyInjection\TransportFactory;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;
Expand Down Expand Up @@ -34,17 +34,11 @@ public function getConfigTreeBuilder(): TreeBuilder
$consumptionNode = $rootNode->children()->arrayNode('consumption');
$transportFactory->addQueueConsumerConfiguration($consumptionNode);

$clientFactory = new ClientFactory('default');
$clientNode = $rootNode->children()->arrayNode('client');
$clientFactory->addClientConfiguration($clientNode, $this->debug);

$rootNode->children()
->arrayNode('client')->children()
->booleanNode('traceable_producer')->defaultValue($this->debug)->end()
->scalarNode('prefix')->defaultValue('enqueue')->end()
->scalarNode('app_name')->defaultValue('app')->end()
->scalarNode('router_topic')->defaultValue('default')->cannotBeEmpty()->end()
->scalarNode('router_queue')->defaultValue('default')->cannotBeEmpty()->end()
->scalarNode('router_processor')->defaultValue(RouterProcessor::class)->end()
->scalarNode('default_processor_queue')->defaultValue('default')->cannotBeEmpty()->end()
->integerNode('redelivered_delay_time')->min(0)->defaultValue(0)->end()
->end()->end()
->booleanNode('job')->defaultFalse()->end()
->arrayNode('async_events')
->addDefaultsIfNotSet()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Enqueue\Client\CommandSubscriberInterface;
use Enqueue\Client\TopicSubscriberInterface;
use Enqueue\JobQueue\Job;
use Enqueue\Symfony\DependencyInjection\ClientFactory;
use Enqueue\Symfony\Client\DependencyInjection\ClientFactory;
use Enqueue\Symfony\DependencyInjection\TransportFactory;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Config\Resource\FileResource;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Enqueue\Bundle\Tests\Unit\DependencyInjection;

use Enqueue\Bundle\DependencyInjection\Configuration;
use Enqueue\Client\RouterProcessor;
use Enqueue\Test\ClassExtensionTrait;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\Definition\ConfigurationInterface;
Expand Down Expand Up @@ -94,7 +93,7 @@ public function testShouldSetDefaultConfigurationForClient()
'client' => [
'prefix' => 'enqueue',
'app_name' => 'app',
'router_processor' => RouterProcessor::class,
'router_processor' => 'enqueue.client.default.router_processor',
'router_topic' => 'default',
'router_queue' => 'default',
'default_processor_queue' => 'default',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Enqueue\Symfony\DependencyInjection;
namespace Enqueue\Symfony\Client\DependencyInjection;

use Enqueue\Client\ChainExtension;
use Enqueue\Client\Config;
Expand All @@ -21,7 +21,9 @@
use Enqueue\Consumption\QueueConsumer;
use Enqueue\Rpc\RpcFactory;
use Enqueue\Symfony\ContainerProcessorRegistry;
use Enqueue\Symfony\DependencyInjection\FormatClientNameTrait;
use Interop\Queue\Context;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Reference;
Expand All @@ -47,6 +49,21 @@ public function __construct(string $name)
$this->name = $name;
}

public function addClientConfiguration(ArrayNodeDefinition $builder, bool $debug): void
{
$builder->children()
->booleanNode('traceable_producer')->defaultValue($debug)->end()
->scalarNode('prefix')->defaultValue('enqueue')->end()
->scalarNode('app_name')->defaultValue('app')->end()
->scalarNode('router_topic')->defaultValue('default')->cannotBeEmpty()->end()
->scalarNode('router_queue')->defaultValue('default')->cannotBeEmpty()->end()
->scalarNode('router_processor')->defaultValue($this->format('router_processor'))->end()
->scalarNode('default_processor_queue')->defaultValue('default')->cannotBeEmpty()->end()
->integerNode('redelivered_delay_time')->min(0)->defaultValue(0)->end()
->end()->end()
;
}

public function build(ContainerBuilder $container, array $config): void
{
$container->register($this->format('context'), Context::class)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?php

namespace Enqueue\Tests\Symfony\DependencyInjection;
namespace Enqueue\Tests\Symfony\Client\DependencyInjection;

use Enqueue\Symfony\DependencyInjection\ClientFactory;
use Enqueue\Symfony\Client\DependencyInjection\ClientFactory;
use Enqueue\Test\ClassExtensionTrait;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;
Expand Down