Skip to content

Fix functional testing documentation example #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix functional testing documentation example #417

wants to merge 1 commit into from

Conversation

sbacelic
Copy link
Contributor

TracebleProducer is registered as ProducerInterface::class

TracebleProducer is registered as ProducerInterface::class
@makasim
Copy link
Member

makasim commented Apr 4, 2018

There must be a traceable producer service registered https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/enqueue-bundle/DependencyInjection/EnqueueExtension.php#L110

If set the option true.

What are the reasons to change this?

@sbacelic
Copy link
Contributor Author

Ah, then TraceableProducer::class service needs to be made public to make it work with Symfony ^4 as:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException : The "Enqueue\Client\TraceableProducer" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

Shall I submit new PR with this change?

@makasim
Copy link
Member

makasim commented Apr 10, 2018

PR is welcome

@sbacelic
Copy link
Contributor Author

Did in #422

@sbacelic sbacelic closed this Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants