Skip to content

MongoDB - Add combined index #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2023
Merged

MongoDB - Add combined index #1283

merged 3 commits into from
Mar 1, 2023

Conversation

ddziaduch
Copy link
Contributor

Hey there 👋

In Printify we are utilizing this library quite heavily.

Recently we had an incident with the super high CPU and I/O usage in MongoDB.

With multiple queues and thousands of messages per queue, MongoDB is doing a full collection scan.

The combined index solves that.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
With multiple queues and thousands of messages, MongoDB is doing a full collection scan.

The combined index solves that.
@ddziaduch ddziaduch changed the title Add combined index MongoDB - Add combined index Jan 27, 2023
Copy link
Contributor

@andrewmy andrewmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective. @makasim take a look please

@ddziaduch
Copy link
Contributor Author

Hey @makasim !

I see that you have triggered the CI but it failed somehow. I've checked it but seems that nothing is related to my changes. Not sure what to do next 🤷‍♂️

@makasim
Copy link
Member

makasim commented Feb 7, 2023

I could merge only if CI is green. Someone has to fix it. I won't do it.

@ddziaduch
Copy link
Contributor Author

@makasim can you rerun the CI?

@andrewmy
Copy link
Contributor

andrewmy commented Feb 8, 2023

#1284 should fix the CI, @makasim please take a look

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ddziaduch
Copy link
Contributor Author

Hey @makasim, I merged a fix from @andrewmy

This should unblock the CI.

Could you please run the CI once again?

Thanks

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ddziaduch
Copy link
Contributor Author

@makasim my apologies for pinging you constantly, but this is quite a priority for Printify.

I've merged another change proposed by @andrewmy so maybe this time the CI will be green 🤞

@makasim makasim merged commit 58dc83a into php-enqueue:master Mar 1, 2023
@ddziaduch
Copy link
Contributor Author

@makasim can you please create a new tag? I would like to upgrade dependencies in Printify projects. Thanks in advance 🙏🏻

@makasim
Copy link
Member

makasim commented Mar 13, 2023

I have some problems with git subtree split on my machine. I'll try to cut some time to fix it. Feel free to ping me from time to time.

@makasim
Copy link
Member

makasim commented Mar 18, 2023

I've recently migrated to mac m1 and it seems split-sh does not work on m1.
So, currently, I cannot push changes from enqueue-dev repo to package repos.

I've tried to compile it at my machine, without luck so far.
I'll try to work around it somehow, but it would take more time than I've thought.

@makasim
Copy link
Member

makasim commented Mar 18, 2023

done

php-enqueue/mongodb@8b02e69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants