-
Notifications
You must be signed in to change notification settings - Fork 440
Allow ext-rdkafka 6 usage #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
@makasim can this be merged?
Approved CI run. |
Thanks @makasim It seems CI errors are identical to the |
Master has to be fixed before I can merge this PR. I understand that it has nothing to do with your changes but master has to be green, otherwise it all become mess pretty soon. |
No problem. I understand that 👍🏼 Thanks for your feedback |
Ping |
CI fails. Should be green before I can merge. |
@makasim Does someone work on this issue ? Do you need help ? |
Unfortunately, no one I am aware of. |
It's not a code issue, but rather a service required for testing fails to start :/ |
@Steveb-p @makasim based on
and after
So the root cause of failed jobs is |
I'm going to work on this issue. 2 fixes are possible:
|
I've just opened a PR (#1237) to fix the CI on the According to my fork, it should be OK: https://github.com/jdecool/enqueue-dev/actions/runs/1791778929. |
@makasim since this is a simple change I'm taking the liberty of merging it. |
Thanks |
ext-rdkafka
v6.0 is available.Allow its usage in this library.
According to the release note, there's no BC breaks.