Skip to content

Allow ext-rdkafka 6 usage #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Allow ext-rdkafka 6 usage #1233

merged 1 commit into from
Feb 8, 2022

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Jan 20, 2022

ext-rdkafka v6.0 is available.

Allow its usage in this library.

According to the release note, there's no BC breaks.

Copy link
Contributor

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

@makasim can this be merged?

@makasim
Copy link
Member

makasim commented Jan 27, 2022

Approved CI run.

@jdecool
Copy link
Contributor Author

jdecool commented Jan 27, 2022

Thanks @makasim

It seems CI errors are identical to the master branch and it's not related to my PR.

@makasim
Copy link
Member

makasim commented Jan 27, 2022

Master has to be fixed before I can merge this PR. I understand that it has nothing to do with your changes but master has to be green, otherwise it all become mess pretty soon.

@jdecool
Copy link
Contributor Author

jdecool commented Jan 27, 2022

No problem. I understand that 👍🏼

Thanks for your feedback

@mamchyts
Copy link

Ping

@Wirone
Copy link

Wirone commented Feb 3, 2022

This PR also fixes #1234 (#1236 duplicates this one, I'll close it).

@makasim
Copy link
Member

makasim commented Feb 3, 2022

CI fails. Should be green before I can merge.

@jdecool
Copy link
Contributor Author

jdecool commented Feb 3, 2022

CI fails. Should be green before I can merge.

@makasim Does someone work on this issue ?

Do you need help ?

@makasim
Copy link
Member

makasim commented Feb 3, 2022

@makasim Does someone work on this issue ?

Unfortunately, no one I am aware of.
I don't plan working on it too.

@Steveb-p
Copy link
Contributor

Steveb-p commented Feb 3, 2022

It's not a code issue, but rather a service required for testing fails to start :/

@Wirone
Copy link

Wirone commented Feb 3, 2022

@Steveb-p @makasim based on Dockerfile I've created locally simple stack:

services:
  thruway:
    build: .

and after docker-compose up -d I see that thruway service exits with 255 status. Looking at container's logs I see:

rnd-thruway-1  | PHP Fatal error:  Declaration of Thruway\Logging\ConsoleLogger::log($level, $message, array $context = []) must be compatible with Psr\Log\AbstractLogger::log($level, Stringable|string $message, array $context = []): void in /thruway/vendor/thruway/client/src/Logging/ConsoleLogger.php on line 22

So the root cause of failed jobs is voryx/thruway used in makasim/nginx-php-fpm:latest-all-exts image. Probably not compatible with PHP8 or Composer dependencies are not resolved correctly.

@jdecool
Copy link
Contributor Author

jdecool commented Feb 3, 2022

I'm going to work on this issue.

2 fixes are possible:

  • Use the PHP 7.4 version of the docker makasim/nginx-php-fpm:latest-all-exts image instead of the latest.
  • Fix the issue in the Thruway\Logging\ConsoleLogger class in the thruway/client package

@jdecool
Copy link
Contributor Author

jdecool commented Feb 3, 2022

I've just opened a PR (#1237) to fix the CI on the master branch.

According to my fork, it should be OK: https://github.com/jdecool/enqueue-dev/actions/runs/1791778929.

@Steveb-p
Copy link
Contributor

Steveb-p commented Feb 8, 2022

@makasim since this is a simple change I'm taking the liberty of merging it.

@Steveb-p Steveb-p merged commit 62afec6 into php-enqueue:master Feb 8, 2022
@jdecool jdecool deleted the allow-rdkafka-6 branch February 8, 2022 12:46
@jdecool
Copy link
Contributor Author

jdecool commented Feb 8, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants